replaced all deadlinks with wayback links #1143
Conversation
|
Thanks! It seems like all the shape functions are missing from defelement? Not just the 3rd order quadrilaterals? I cannot see them neither on computer nor phone... Then I think we should fix it upstream if it isn't just a single interpolation. Could be related to DefElement/DefElement#382? But I don't know how their website is built, so not sure... Do you want to open at issue at defelement? (If not, I can do of course) |
|
Correct! The shape functions are missing from defelement in general. This appears to be the case for more than just the 3rd order lagrange on quadrilaterals. The wayback links show you the shape functions, so it's a temporary fix. I have opened an issue now at https://github.com/DefElement/DefElement |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1143 +/- ##
=======================================
Coverage 93.59% 93.59%
=======================================
Files 39 39
Lines 6087 6087
=======================================
Hits 5697 5697
Misses 390 390 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Knut Andreas Meyer <[email protected]>
… shape function Co-authored-by: Knut Andreas Meyer <[email protected]>
This PR address issue #1142
Replaced dead links that provided information about the finite elements with the corresponding wayback links. This is still not ideal since in some cases, the wayback machine did not archive a related URL (e.g., the definition for the basis functions for the 1st order BubbleEnrichedLagrange on a triangular element is not accessible: https://web.archive.org/web/20250000000000*/https://defelement.com/elements/examples/triangle-bubble-enriched-lagrange-1.html).
A possible solution that I plan on trying this week is to add tosrc/interpolations.jlpermalinks to the files from https://github.com/DefElement/DefElement that provide information on the interpolation definitions but whose HTML pages are not archived by the wayback machine. The DefElement files that provide this interpolation information should be findable in the commit history of https://github.com/DefElement/DefElement. The PR should remain in draft mode until this can be resolved.